dxbjavid commented on PR #3585: URL: https://github.com/apache/thrift/pull/3585#issuecomment-4642003355
good point, added a test in testbinaryprotocol.c. it stands up a memory buffer with a small recursion_limit on its configuration, writes nested struct field headers a fair way past that limit, and asserts skip returns -1 with THRIFT_PROTOCOL_ERROR_DEPTH_LIMIT. there's also a shallow case nested within the limit that still skips cleanly, so the guard doesn't trip on normal input. used the binary protocol over the buffer so it stays self-contained, no socket needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
