Jens-G commented on PR #3529: URL: https://github.com/apache/thrift/pull/3529#issuecomment-4636538162
### Code review Found 1 issue: 1. `js:bigint` defaults to `true`, so regenerating existing `--gen js:node` definitions switches `int64` struct fields/args/returns from `node-int64` `Int64` to native `bigint` — a compile-time break for TS consumers and a runtime break for plain-JS consumers that call `Int64` methods on i64 fields. The opt-out (`bigint=false`) and README are in place; worth confirming maintainers want this defaulted on rather than opt-in, given the analogous (narrower) THRIFT-4675 was classified as a Breaking Change. (backward-compatibility of an intentional default) https://github.com/apache/thrift/blob/75e334f491366ccf9310270e9500bbb12095da2d/compiler/cpp/src/thrift/generate/t_js_generator.cc#L74-L78 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
