Jens-G opened a new pull request, #3581:
URL: https://github.com/apache/thrift/pull/3581

   ## Run the Haxe library unit tests (neko) in CI
   
   Until now the Haxe **library unit tests** never ran in CI — only the codegen 
tests (`lib-haxe-codegen`), and the autotools `make check` path is disabled 
everywhere (`--without-haxe` in `build.yml` and `sca.yml`).
   
   This adds a step to the existing `lib-haxe-codegen` job that builds the test 
harness for the lightweight **neko** target and runs the standalone 
`StreamTest` and `RecursionLimitTest` (Main's *Normal* mode). It reuses the 
toolchain that job already provisions — Haxe + neko, the `uuid` haxelib, and 
the `thrift` compiler artifact on `PATH` — so it's a small, self-contained 
addition rather than reviving the heavier cpp/php `make check`. A failed 
assertion throws and `Sys.exit(1)`s, so a regression fails the job (verified: a 
deliberately failing mode exits non-zero).
   
   Validated locally on neko (ubuntu, same as the runner): the Normal-mode run 
is green on current `master`.
   
   ### Not run (yet)
   - **multiplex** — needs a client + server.
   - **constants** (`ConstantsTest`) — it constructs a `TMemoryStream`, whose 
write path is currently broken on the neko target (uninitialized `Position` → 
`"Invalid operation (+)"`); `ConstantsTest` therefore fails on neko today. 
That's fixed by #3579 (THRIFT-6065); once it lands, running `neko bin/Test.n 
constants` here is a one-line follow-up.
   
   Independent of #3579/#3580 — but note that as those merge, the Normal-mode 
run here automatically starts exercising the in-memory `TMemoryStream` versions 
of the stream/recursion tests.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to