sveneld opened a new pull request, #3566: URL: https://github.com/apache/thrift/pull/3566
<!-- Explain the changes in the pull request below: --> Builds on @Jens-G's work in #3535 (THRIFT-6029) and adds a follow-up fix: - Adds negative-size guards in `readMapBegin`, `readListBegin`, `readSetBegin`, and `readString` in `TBinaryProtocol` (from #3535). - Adds 4 PHPUnit tests in `TBinaryProtocolTest.php` covering all guarded methods (from #3535). - Replaces `willReturnOnConsecutiveCalls` (deprecated in PHPUnit 10.3, removed in PHPUnit 12) with the `willReturnCallback` + static iteration counter pattern already used throughout `TBinaryProtocolTest`. `composer.json` allows `phpunit/phpunit: ^10.5 || ^11.0 || ^12.0 || ^13.0`, so the deprecated API would break the suite on 12+. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? — [THRIFT-6029](https://issues.apache.org/jira/browse/THRIFT-6029) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [ ] Did you squash your changes to a single commit? — kept 2 commits to preserve original authorship of @Jens-G; happy to squash on request. - [x] Did you do your best to avoid breaking changes? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
