sveneld opened a new pull request, #3533: URL: https://github.com/apache/thrift/pull/3533
<!-- Explain the changes in the pull request below: --> Resolves [THRIFT-1636](https://issues.apache.org/jira/browse/THRIFT-1636). The original ask was to drop `?>` closing tags from generated PHP. That happened years ago (the generator emits no `?>` anywhere — verified with grep on `compiler/cpp/src/thrift/generate/t_php_generator.cc`, and the regenerated stubs under `lib/php/test/Resources/packages/` all end with `}` and a newline). No test pins that behaviour today. This adds a phpunit data-provider that walks every generated `.php` under `lib/php/test/Resources/packages/` and asserts the file does not end with `?>`. If the generator ever regresses (or someone adds a hand-written fixture with a closing tag into one of those package dirs), the lib-php CI job surfaces it immediately. - [x] [Apache JIRA](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket: THRIFT-1636 - [x] Title follows `THRIFT-NNNN: …` - [x] Single squashed commit - [x] No breaking change — test-only - [ ] `[skip ci]` (n/a — test addition) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
