sveneld commented on PR #3515: URL: https://github.com/apache/thrift/pull/3515#issuecomment-4522377346
@kpumuk Thanks — addressed both points in 025863b5e: * Implemented oneway fast-response in the cli-server router: the request is peeked for `TMessageType::ONEWAY`, and on a match we send an empty HTTP 200 (`Content-Length: 0`) and `pcntl_fork()` the handler so the client's oneway call returns immediately, matching the THttpServer pattern from THRIFT-6021. This drops the four `php-java_*_http-ip` known_failures entries. * Removed the four `php-cpp_*_http-ip` known_failures entries on the assumption that #3514 lands before this PR — let me know if you'd prefer I re-add them as a temporary hedge until #3514 merges. While I was in there also collapsed the `if/elseif` cascade in `TestClient.php` to two `match` expressions and dropped the dead `TSocket` assignment / unused `$hosts`/`$logger`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
