sveneld commented on code in PR #3443:
URL: https://github.com/apache/thrift/pull/3443#discussion_r3178473241
##########
.github/workflows/sca.yml:
##########
@@ -146,6 +185,137 @@ jobs:
-i lib/c_glib/test/gen-cpp \
--error-exitcode=1 -j2 lib/c_glib/src lib/c_glib/test
test/c_glib/src tutorial/c_glib
+ lib-python:
+ needs: compiler
+ runs-on: ubuntu-24.04
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #
v6.0.2
+ with:
+ persist-credentials: false
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ # shellcheck disable=SC2086
+ sudo apt-get install -y --no-install-recommends g++ $BUILD_DEPS
+
+ - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #
v6.2.0
+ with:
+ python-version: "3.12"
+
+ - name: Install Python test dependencies
+ run: |
+ python -m pip install --upgrade pip setuptools wheel flake8
+
+ - name: Configure
+ run: |
+ ./bootstrap.sh
+ # shellcheck disable=SC2086
+ ./configure $CONFIG_ARGS_FOR_SCA
+
+ - uses:
actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Generate Python thrift files
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+ make -j"$(nproc)" -C test/py precross
+
+ - name: Run flake8
+ run: flake8
+
+ lib-php:
+ needs: compiler
+ runs-on: ubuntu-24.04
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #
v6.0.2
+ with:
+ persist-credentials: false
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ # shellcheck disable=SC2086
+ sudo apt-get install -y --no-install-recommends g++ $BUILD_DEPS
+
+ - name: Set up PHP
+ uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f
# master
+ with:
+ # Lowest supported PHP version
+ php-version: "8.1"
+ extensions: mbstring, xml, curl, pcntl
+
+ - name: Configure
+ run: |
+ ./bootstrap.sh
+ # shellcheck disable=SC2086
+ ./configure $CONFIG_ARGS_FOR_SCA
+
+ - uses:
actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Generate PHP thrift files
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+ make -j"$(nproc)" -C lib/php/test stubs
+ make -j"$(nproc)" -C test/php precross
+
+ - name: Run phpcs
+ run: |
+ composer install --quiet
+ ./vendor/bin/phpcs
Review Comment:
I see that generated php files get many errors, I plan to fix style for
generated classes.
As temporary solution phpcs can be run like this
./vendor/bin/phpcs --ignore=*/test/Resources/*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
