kpumuk commented on PR #3414: URL: https://github.com/apache/thrift/pull/3414#issuecomment-4347099409
Heh, found another edge case to cover. Last change fixed for `T_REGULAR`, but user-defined exceptions are also deserialized through `render_struct_sync_read()`. If an exception has an optional union field and a newer server sends a newly-added union variant, older Rust clients will still fail the whole RPC with `UnknownUnionVariant` instead of decoding the exception with that field as `None`, so exception payloads remain non-forward-compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
