kpumuk commented on code in PR #3410:
URL: https://github.com/apache/thrift/pull/3410#discussion_r3127211302
##########
lib/rb/lib/thrift/protocol/compact_protocol.rb:
##########
@@ -417,13 +418,13 @@ def read_varint32()
def read_varint64()
shift = 0
result = 0
- while true
+ MAX_VARINT_BYTES.times do
Review Comment:
This only covers pure Ruby implementation, we also have C extension here
https://github.com/apache/thrift/blob/master/lib/rb/ext/compact_protocol.c#L442
The description also mentions 5 bytes for 32-bit, which is not covered in
the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
