sveneld commented on PR #3405:
URL: https://github.com/apache/thrift/pull/3405#issuecomment-4295207383
You were right, this turned out to be a real issue in the `php:inlined` path.
`TProtocol::skipBinary()` was using `readAll()` as if it returned a byte
count, but in PHP it returns raw string data. The previous tests did not expose
this because the mocks
returned numeric strings.
I fixed the implementation and updated the coverage:
- unit tests now use real `TMemoryBuffer` payloads
- added an integration test for generated `php:inlined` code to verify
skipping unknown/mismatched fields and continuing to parse following fields
correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
