kpumuk commented on PR #3401: URL: https://github.com/apache/thrift/pull/3401#issuecomment-4261803190
Addressed a regression: When `addrinfo.connect(timeout: remaining)` times out for one candidate address, this helper raised `TIMED_OUT` immediately instead of trying the next `Addrinfo` within the still-remaining budget. That breaked multi-homed hosts and dual-stack fallbacks: if the first address blackholes but a later one is reachable before the overall deadline, both `Thrift::Socket#open` and `Thrift::SSLSocket#open` would fail even though the connection could still succeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
