kpumuk commented on code in PR #3387: URL: https://github.com/apache/thrift/pull/3387#discussion_r3076296057
########## lib/rb/ext/compact_protocol.c: ########## Review Comment: Nice catch. I was following the cppcheck complaints and missed this :-( I also noticed that we do not validate the size of varint in Ruby (cpp fails on >10 bytes), but will leave it for the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
