qr243vbi commented on code in PR #3379:
URL: https://github.com/apache/thrift/pull/3379#discussion_r3060367064
##########
lib/go/thrift/server_socket.go:
##########
@@ -44,28 +47,75 @@ func NewTServerSocketTimeout(listenAddr string,
clientTimeout time.Duration) (*T
if err != nil {
return nil, err
}
- return &TServerSocket{addr: addr, clientTimeout: clientTimeout}, nil
+
+ return NewTServerSocketFromAddrTimeout(addr, clientTimeout), nil
}
-// Creates a TServerSocket from a net.Addr
func NewTServerSocketFromAddrTimeout(addr net.Addr, clientTimeout
time.Duration) *TServerSocket {
- return &TServerSocket{addr: addr, clientTimeout: clientTimeout}
+ factory := func(listen bool) (net.Addr, net.Listener, error) {
+ var listener net.Listener
+ var err error
+ if (listen){
+ listener, err = net.Listen(addr.Network(),
addr.String())
+ }
+ return addr, listener, err
+ }
+
+ return NewTServerSocketFromFactoryTimeout(factory, clientTimeout)
}
-func (p *TServerSocket) Listen() error {
+// Allows full customization (TLS, mocks, unix sockets, windows named pipes,
etc.)
Review Comment:
@fishy, suggest changes, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
