markjm commented on PR #3377: URL: https://github.com/apache/thrift/pull/3377#issuecomment-4179440046
Regarding: > Note the test change. I asked about potentially changing this to look more like what the codegen produces here https://github.com/apache/thrift/pull/3349/changes#r3026288637. Currently, this fails because its not marked as frozen but has a erroring setattr the test suite alerted me to another mechanism which something could look frozen which i needed to handle by checking 2 options. with that I dont need to modify the tests ``` // Immutable structs are produced by two codegen paths: // 1. "frozen2" mode: classes inherit from TFrozenBase // 2. "python.immutable" annotation: classes get a __setattr__ that raises TypeError ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
