pkvach commented on PR #3352: URL: https://github.com/apache/thrift/pull/3352#issuecomment-4107105443
> ``` > Run vendor/bin/phpunit -c lib/php/phpunit.xml > PHPUnit 7.5.20 by Sebastian Bergmann and contributors. > > ........E > > Time: 633 ms, Memory: 12.00 MB > > There was 1 error: > > 1) Test\Thrift\Unit\Lib\Factory\TBinaryProtocolFactoryTest::testGetProtocol with data set "allTrue" (true, true) > TypeError: Argument 1 passed to Test\Thrift\Unit\Lib\Factory\TBinaryProtocolFactoryTest::getPropertyValue() must be an instance of Test\Thrift\Unit\Lib\object, instance of Thrift\Protocol\TBinaryProtocol given, called in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 50 > > /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/ReflectionHelper.php:53 > /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php:50 > > ERRORS! > Tests: 9, Assertions: 25, Errors: 1. > ``` Fixed the test failure in the latest commit, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
