pkvach commented on PR #3350: URL: https://github.com/apache/thrift/pull/3350#issuecomment-4104143495
> ``` > There was 1 error: > > 1) Test\Thrift\Unit\Lib\Factory\TBinaryProtocolFactoryTest::testGetProtocol with data set "allTrue" (true, true) > PHPUnit\Framework\Exception: PHP Deprecated: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 49 > Deprecated: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 49 > PHP Deprecated: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 51 > Deprecated: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 51 > PHP Deprecated: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 53 > Deprecated: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/thrift/thrift/lib/php/test/Unit/Lib/Factory/TBinaryProtocolFactoryTest.php on line 53 > > ERRORS! > Tests: 9, Assertions: 24, Errors: 1. > Error: Process completed with exit code 2. > ``` Thanks for pointing that out! I noticed the same issue and created a separate PR to fix the deprecation in tests: https://github.com/apache/thrift/pull/3352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
