CJCombrink commented on code in PR #3330:
URL: https://github.com/apache/thrift/pull/3330#discussion_r2883111980
##########
lib/py/src/ext/types.h:
##########
@@ -76,8 +79,9 @@ enum TType {
T_MAP = 13,
T_SET = 14,
T_LIST = 15,
- T_UTF8 = 16,
- T_UTF16 = 17
+ T_UTF8 = 11,
+ T_UTF16 = 11,
Review Comment:
Calling this out, I am not sure why this is the case but with it as it was
it would not be possible to add UUID support for Python.
`UTF7` just above does the same by mapping it to 11 (`T_STRING`), I
initially thought UTF7 was a typo but it seems like it might be a thing.
Some inputs will be appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
