Jens-G commented on code in PR #3139:
URL: https://github.com/apache/thrift/pull/3139#discussion_r2096449157
##########
lib/cpp/src/thrift/protocol/TJSONProtocol.cpp:
##########
@@ -1087,7 +1087,10 @@ uint32_t TJSONProtocol::readBool(bool& value) {
uint32_t TJSONProtocol::readByte(int8_t& byte) {
auto tmp = (int16_t)byte;
uint32_t result = readJSONInteger(tmp);
- assert(tmp < 256);
+ if (tmp > 255 || tmp < -128) {
Review Comment:
The `byte` type is like all integer types in Thrift a **signed** type. So
not really sure what the intention of the test against < 256 was. Only David
knows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
