dengzhhu653 commented on code in PR #2959:
URL: https://github.com/apache/thrift/pull/2959#discussion_r2067674915
##########
lib/java/src/main/java/org/apache/thrift/server/TServerEventHandler.java:
##########
@@ -37,8 +38,15 @@ public interface TServerEventHandler {
/** Called before the server begins. */
void preServe();
- /** Called when a new client has connected and is about to being processing.
*/
- ServerContext createContext(TProtocol input, TProtocol output);
+ /**
+ * Called when a new client has connected and is about to being processing.
The
+ * remoteSocketAddress and localSocketAddress are null when transport is not
socket based
+ */
+ ServerContext createContext(
Review Comment:
how add a default method in ServerContext to set the address, instead of a
new method in the event handler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
