Jens-G commented on code in PR #3131:
URL: https://github.com/apache/thrift/pull/3131#discussion_r2062730193
##########
lib/java/src/main/java/org/apache/thrift/transport/TServerSocket.java:
##########
@@ -122,6 +126,7 @@ public TSocket accept() throws TTransportException {
throw new TTransportException("Blocking server's accept() may not return
NULL");
}
TSocket socket = new TSocket(result);
+ socket.getConfiguration().deepCopy(configuration_);
Review Comment:
Question: Why is it considered good to have multiple configuration
instances, in opposite to use a shared instance through the whole
transport/protocol stack? What's the added value exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
