Jens-G commented on code in PR #3108:
URL: https://github.com/apache/thrift/pull/3108#discussion_r1976379696
##########
lib/py/src/transport/THttpClient.py:
##########
@@ -111,8 +111,6 @@ def open(self):
timeout=self.__timeout)
elif self.scheme == 'https':
self.__http = http.client.HTTPSConnection(self.host, self.port,
- key_file=self.keyfile,
- cert_file=self.certfile,
timeout=self.__timeout,
Review Comment:
> Deprecated since version 3.6: key_file and cert_file are deprecated in
favor of context. Please use ssl.SSLContext.load_cert_chain() instead, or let
ssl.create_default_context() select the system’s trusted CA certificates for
you.
>
> The check_hostname parameter is also deprecated; the
ssl.SSLContext.check_hostname attribute of context should be used instead.
https://docs.python.org/3/library/http.client.html
Where is the second part of that change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
