emmenlau commented on PR #2633: URL: https://github.com/apache/thrift/pull/2633#issuecomment-2637764196
I've looked through the code for as much as I can, without stepping with a debugger. As far as I can tell, it looks correct and clean now. I agree that the old code seems rather limited, for example in that it `asserts` that the given argument is the end iterator. The new code does look more clean and more versatile. All with a grain of salt, because I did not step through the code. But if it furthermore was tested by @africamonkey , I'd vote for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
