goorjn commented on PR #1714: URL: https://github.com/apache/thrift/pull/1714#issuecomment-2459192022
@cyyever @jeking3 wouldn't it have been more convenient to move the TSSLSocketFactory::setManualOpenSSLInitialization's body to cpp rather than explicitly exporting the variable ? (see https://stackoverflow.com/questions/2479784/exporting-static-data-in-a-dll) Maybe there is a similar trick to avoid to have to explicitly export GlobalOutput variable, but I still haven't looked for it. By the way, I would have preferred to have default static linking for windows, just like previous versions, rather than to have to #define THRIFT_STATIC_DEFINE in my projects to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
