CJCombrink commented on code in PR #3035:
URL: https://github.com/apache/thrift/pull/3035#discussion_r1744815059
##########
lib/c_glib/test/testthrifttestclient.cpp:
##########
@@ -112,8 +112,8 @@ class TestHandler : public ThriftTestIf {
out = thing;
}
- std::string testUuid(const std::string thing) override {
- cout << "[C -> C++] testUuid(\"" << std::hex << thing << "\")" << '\n';
+ apache::thrift::TUuid testUuid(const apache::thrift::TUuid thing) override {
Review Comment:
Unfortunately thirft generates the interface with a copy. Perhaps it is
something I missed when I added the new type because I see the other functions
uses const ref on some arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
