cfriedt commented on PR #2747: URL: https://github.com/apache/thrift/pull/2747#issuecomment-2219366562
@CJCombrink - my PR needs approval to run tests. Can you please approve? This change definitely looks cleaner without the `virutal ... override` destructors. I'm not 100% sure if the virtual keyword is required on the windows class variants, but I think it could probably be removed as well if there are no inheritors. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
