SvenRoederer commented on PR #2993: URL: https://github.com/apache/thrift/pull/2993#issuecomment-2211532957
Sorry for the confusion, but I sorted it out now. The issue only affects v0.20.0, where I found it. I fixed the code on my system for v0.20.0 and tested the generator. When adapting my fix to current master, I broke the code as pointed out by @Jens-G. Looking in depth I realized, that current master has already a fix for the issue. The trick is, that this fix was included to [4f1839575f3af168f960110414114255bd344203](https://github.com/apache/thrift/commit/4f1839575f3af168f960110414114255bd344203#diff-171cba564f81e70ad05350c5b6be4131a21c4a4c0b1f608954d9cb3f55ffc6deR1194) ("implement full deprecation support"). I did not expect this change to fix the syntax-error, while just following the commit messages. Finally I just updated the PR to mark the change only relevant for v0.20.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
