Jens-G commented on code in PR #2929:
URL: https://github.com/apache/thrift/pull/2929#discussion_r1644978642
##########
compiler/cpp/src/thrift/generate/t_py_generator.cc:
##########
@@ -3009,22 +3001,19 @@ THRIFT_REGISTER_GENERATOR(
" zope.interface: Generate code for use with zope.interface.\n"
" twisted: Generate Twisted-friendly RPC services.\n"
" tornado: Generate code for use with Tornado.\n"
- " no_utf8strings: Do not Encode/decode strings using utf8 in the
generated code. Basically "
- "no effect for Python 3.\n"
+ " no_utf8strings: Do not Encode/decode strings using utf8 in the
generated code. Basically no effect for Python 3.\n"
" coding=CODING: Add file encoding declare in generated file.\n"
" slots: Generate code using slots for instance members.\n"
" dynamic: Generate dynamic code, less code generated but
slower.\n"
" dynbase=CLS Derive generated classes from class CLS instead of
TBase.\n"
- " dynfrozen=CLS Derive generated immutable classes from class CLS
instead of "
- "TFrozenBase.\n"
+ " dynfrozen=CLS Derive generated immutable classes from class CLS
instead of TFrozenBase.\n"
" dynexc=CLS Derive generated exceptions from CLS instead of
TExceptionBase.\n"
- " dynfrozenexc=CLS Derive generated immutable exceptions from CLS
instead of "
- "TFrozenExceptionBase.\n"
+ " dynfrozenexc=CLS Derive generated immutable exceptions from CLS
instead of TFrozenExceptionBase.\n"
" dynimport='from foo.bar import CLS'\n"
" Add an import line to generated code to find the
dynbase class.\n"
" package_prefix='top.package.'\n"
" Package prefix for generated files.\n"
" old_style: Deprecated. Generate old-style classes.\n"
- " enum: Generates Python's IntEnum, connects thrift to
python enums. Python 3.4 "
- "and higher.\n"
- " type_hints: Generate type hints in write method, including
IntEnum generation.\n")
+ " enum: Generates Python's IntEnum, connects thrift to
python enums. Python 3.4 and higher.\n"
+ " type_hints: Generate type hints and type checks in write method,
including IntEnum generation.\n"
Review Comment:
ok thanks for clarifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
