sveneld commented on code in PR #2983:
URL: https://github.com/apache/thrift/pull/2983#discussion_r1624953910
##########
lib/php/lib/Protocol/TProtocol.php:
##########
@@ -181,7 +181,7 @@ abstract public function readString(&$str);
* The skip function is a utility to parse over unrecognized date without
* causing corruption.
*
- * @param TType $type What type is it
+ * @param int $type What type is it
Review Comment:
Before PHP7 phpdoc was used for defining types in php. This docblock is just
for code understanding. Based on this doc block IDE give a suggestions for
argument. TType is not a possible type for argument which will come to this
method, integer value will come. That's why @rtm-ctrlz offer to write a real
type of this function. And I suggest to add comment where the possible values
is defined.
When I will return to my plan of migrating thrift to php7 with type
declaration i will update this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
