CJCombrink commented on code in PR #2977:
URL: https://github.com/apache/thrift/pull/2977#discussion_r1604425849
##########
compiler/cpp/src/thrift/generate/t_go_generator.cc:
##########
@@ -4286,6 +4311,32 @@ void t_go_generator::parse_go_tags(map<string,string>*
tags, const string in) {
}
}
+void t_go_generator::generate_deprecation_comment(ostream& out, map<string,
vector<string>>& annotations) {
Review Comment:
Is there a reason why `annotations` are not const? is there an expectation
that it will be modified inside this function at some time?
```suggestion
void t_go_generator::generate_deprecation_comment(ostream& out, const
map<string, vector<string>>& annotations) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
