ctubbsii commented on code in PR #2962: URL: https://github.com/apache/thrift/pull/2962#discussion_r1567862968
########## lib/py/Makefile.am: ########## @@ -45,7 +45,7 @@ all-local: py3-build # Old version (can't put inline because it's not portable). #$(PYTHON) setup.py install --prefix=$(prefix) --root=$(DESTDIR) $(PYTHON_SETUPUTIL_ARGS) install-exec-hook: - $(PYTHON) setup.py install --root=$(DESTDIR) --prefix=$(PY_PREFIX) $(PYTHON_SETUPUTIL_ARGS) Review Comment: Here's more background for it: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html There is a link to https://setuptools.pypa.io/en/latest/userguide/declarative_config.html The short answer is: no, you probably don't need setup.py, and should probably be using setuptools' declarative config file, setup.cfg (if you need one at all). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
