langke1988 commented on PR #2953: URL: https://github.com/apache/thrift/pull/2953#issuecomment-2028717854
Please make sure to submit this modification. TSocket::write call write_partial, which may throw TTransportException. Therefore, TSocket::write must catch and throw this exception, otherwise the following issues may occur: I have multiple Thrift servers, and clients connect to the server each time by catching exceptions to determine if the server is available, thereby achieving high availability. However, TSocket::write did not throw this exception, causing my high availability to fail. After modifying this code, the problem disappeared. ---- Replied Message ---- | From | Jens ***@***.***> | | Date | 3/31/2024 01:03 | | To | ***@***.***> | | Cc | ***@***.***>, ***@***.***> | | Subject | Re: [apache/thrift] fix 1 bug about TSocket::write (PR #2953) | Closed #2953. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
