emmenlau commented on PR #2943: URL: https://github.com/apache/thrift/pull/2943#issuecomment-1986363604
> (_Personally_)I don't think it is a matter of taste. `std::endl`'s claim to fame (if I can phrase it like that) is that it forces a newline and flush the stream. Well we are certainly on the same page when it comes to `std::endl`, as this has a number of significant drawbacks! But the code in question is already using `\n` rather than `std::endl`. The main difference is that it is concatenating every time with `<<` which may have a negative performance impact. The impact on readability is (in my humble opinion) debatable, because I can see also advantages of recognizing `<< endl <<` as a clear sign of newline, whereas "hello\nworld" may not jump as much into the eye of the reader. In any case, I'm ok with the PR, but without a strong opinion pro or con on my side :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
