juliethecao opened a new pull request, #5359:
URL: https://github.com/apache/texera/pull/5359
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
Extends the `/request-review` comment command in
`.github/workflows/comment-commands.yml`
so that when called with **no `@mention` arguments**, it automatically
identifies reviewers
via `git blame` on the PR's changed files, rather than requiring the author
to name someone
explicitly.
`/request-review` with no arguments runs `git blame -p <base-sha>` on each
changed file, finds the most recent commit author per file, resolves their
GitHub login,
and calls `requestReviewers` — filtering out the PR author, bots, and
accounts with no
linked GitHub login.
This makes `/request-review` a zero-configuration entry point for
contributors unfamiliar
with who owns a given area of the codebase.
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
Closes #5244
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the
PR
is tested with existing test cases. Make sure to include/update test cases
that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please clarify
how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were not
added,
please describe why they were not added and/or why it was difficult to add.
-->
Unit tests for the blame-parsing and reviewer-selection logic were written
and run locally.
The test file covers:
- **Basic blame parsing**: `latestBlameCommit` picks the commit with the
highest
`author-time` across multiple blamed blocks
- **Missing `author-time`**: returns `null` when the field is absent; file
is skipped
- **All files produce reviewers**: three files with distinct authors and a
non-overlapping
PR author returns all three logins
- **PR author filtered**: a file whose blame points to the PR author is
excluded
- **Case-insensitive author filter**: `Alice` vs `alice` is treated as the
same person
- **Bot commits filtered**: accounts with `type: 'Bot'` are excluded
- **Blame throws (new file at base)**: a file absent at the base SHA is
skipped; other
files still contribute reviewers
- **All candidates filtered**: when every blame candidate is the PR author,
returns `[]`
End-to-end verification was done by opening a test PR on the fork and
commenting
`/request-review` with no arguments; the workflow run successfully called
`requestReviewers` with the blame-detected login.
Test file and run results via test PR:
[`test-request-review-no-args`](https://github.com/juliethecao/texera/pull/3)
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Co-authored with Claude Sonnet 4.6 in compliance with ASF guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
