Ma77Ball opened a new pull request, #5324:
URL: https://github.com/apache/texera/pull/5324

   ### What changes were proposed in this PR?
   - Removed the redundant `computingUnitStatusSubscription` field (and its 
`.add()` wrapper and `ngOnDestroy` unsubscribe) in `menu.component.ts`: the 
inner stream is already piped through `untilDestroyed(this)`, so the manual 
aggregator did nothing.
   - Replaced the manually managed `durationUpdateSubscription` with a 
declarative `switchMap` pipe, so each `ExecutionDurationUpdateEvent` cancels 
the previous 1s timer and starts a new one only while running, instead of 
imperatively unsubscribing and reassigning a field.
   - Dropped the now-unused `Subscription` import, leaving the component on a 
single consistent cleanup style (`untilDestroyed`).
   ### Any related issues, documentation, or discussions?
   Closes: #5323
   ### How was this PR tested?
   - Ran `ng test 
--include='src/app/workspace/component/menu/menu.component.spec.ts'`: all 42 
tests pass.
   - Ran `yarn format:fix` (no files changed).
   - Behavior-preserving refactor: same elapsed-timer cadence, same 
base-duration updates, same teardown on destroy.
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.7 in compliance with ASF


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to