bobbai00 commented on PR #5160: URL: https://github.com/apache/texera/pull/5160#issuecomment-4583481412
Good catch — you're right. Removing the `body/visibility` flip regressed #4027: the mini-map shares the JointJS model but has no `hide-region` class, so without the per-element attribute it kept rendering the hulls when the toggle was off. I've restored the attribute flip alongside the `hide-region` class toggle. So now: - **Main canvas** — hidden via the `hide-region` CSS class (`display: none`), which fixes #5120. - **Mini-map** — hidden via the per-element `body/visibility` attribute, which keeps #4027 fixed. Both mechanisms are kept and documented inline so the loop isn't mistaken for dead code again. Also added unit tests covering both toggles (region + status), the status-label repositioning, and the default canvas classes. Verified the Regions and Status toggles locally on both surfaces. Ready for another look — thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
