Ma77Ball commented on code in PR #5151:
URL: https://github.com/apache/texera/pull/5151#discussion_r3293760472
##########
frontend/src/app/app-routing.module.ts:
##########
@@ -174,18 +167,10 @@ routes.push({
],
});
-// default route renders the workspace editor directly; if userSystem is
enabled at runtime,
-// AppComponent will navigate to DASHBOARD_ABOUT instead.
-routes.push({
- path: "",
- component: WorkspaceComponent,
- canActivate: [rootRedirectGuard],
-});
-
Review Comment:
CI runs nx build gui:build:production, which invokes the Angular/TypeScript
compiler. Any unresolved identifier is a hard error. app-routing.module.ts:175
references rootRedirectGuard, but that guard is never defined or imported
anywhere in the repo — grep -r "rootRedirectGuard" src/ returns only the line
that uses it. The build aborts before the tests run.
> [!NOTE]
> Even if the guard existed, this route is dead code — the route at line 47
already claims path: "", so Angular would never reach the second "" route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
