bobbai00 commented on PR #4387: URL: https://github.com/apache/texera/pull/4387#issuecomment-4309950510
> LGTM in general. > > * Python names should be PEP-503 normalized (e.g. `huggingface-hub`, not `huggingface_hub`) so a future checker can match without extra logic. > * Do we have a plan to automate this process? Do we have to update these two files each time we add a new dependency? It's better to find a systemic solution. > > We need additional approvals on this PR. #4451 adds an automate check to detect if there is any new libraries introduced but does not appear in the `LICENSE-binary`. But adding a new library and its license still remains as a manual process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
