xuang7 commented on PR #4351: URL: https://github.com/apache/texera/pull/4351#issuecomment-4290141804
> Can we add test cases to catch this problem? Discussed this with @carloea2, please correct me if I missed anything. We already have PythonCodeRawInvalidTextSpec, which runs py_compile on all generated operator code, but it can't catch this bug. mode=lines is syntactically valid Python, so it only fails at runtime with a NameError. A test that would catch this issue would need to execute the generated code with real data and Plotly imported. I'm not sure the added test complexity is worth it right now. Could we merge this first to unblock the broken operators, and then follow up with a more meaningful integration test if needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
