xuang7 commented on code in PR #4349:
URL: https://github.com/apache/texera/pull/4349#discussion_r3053747286
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/util/LakeFSStorageClient.scala:
##########
@@ -334,12 +362,12 @@ object LakeFSStorageClient {
* @return List of uncommitted object stats.
*/
def retrieveUncommittedObjects(repoName: String): List[Diff] = {
- branchesApi
- .diffBranch(repoName, branchName)
- .execute()
- .getResults
- .asScala
- .toList
+ fetchAllPages[Diff] { after =>
Review Comment:
`fetchAllPages` returns all pages as the final result, and it relies on the
provided fetch function to retrieve one page at a time. The `after` parameter
is the cursor passed into each request. I will add a comment to make this
clearer. Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
