gracecluvohio commented on PR #4331: URL: https://github.com/apache/texera/pull/4331#issuecomment-4190204935
> I have three questions: > > 1. We still have this old interface to create a computing unit. Don't we need to remove it? > > <img alt="Image" width="372" height="167" src="https://private-user-images.githubusercontent.com/143021053/573699688-4731432f-5d8b-4f2e-be4d-2df2452081c5.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzU0MzA3NzcsIm5iZiI6MTc3NTQzMDQ3NywicGF0aCI6Ii8xNDMwMjEwNTMvNTczNjk5Njg4LTQ3MzE0MzJmLTVkOGItNGYyZS1iZTRkLTJkZjI0NTIwODFjNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNDA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDQwNVQyMzA3NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZGY0MDZiYWVkYzI5YjExODliOTBhMzRmYWQyY2EzNDJjZTJjMzVmMTA2YTJiMDg1ZjFhN2ExZDVjMzlkNWVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ogQrQDcfTwbBJk-_-QZBfEHr-AXnPx2rTN9CDSXPUAM";> > 2. We have a feature to share computing unit to other users and seems like it's missing in the new tab. Is this intentional? > 3. If the code changes you are making are 100% reusing the old computing unit's logic, you can safely ignore the comments below. However, if that's the case, we have two duplicate codes in our codebase so I want you to refactor the code to remove duplicates. 1. I think having both features is helpful. Having both would allow us to manage computing units quickly from within a workflow (and choose one to run your workflow) and also manage them from one centralized place. @chenlica what do you think? 2. It was not intentional to exclude sharing, I can work on adding it though. 3. I agree, there is a decent amount of code duplication. I can extract some of the duplication out into `computing-unit.util.ts` or maybe create another component. However they're not exact dupilcates as the old computing unit component's logic also interacts with workflow executions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/143021053/573699688-4731432f-5d8b-4f2e-be4d-2df2452081c5.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzU0MzA3NzcsIm5iZiI6MTc3NTQzMDQ3NywicGF0aCI6Ii8xNDMwMjEwNTMvNTczNjk5Njg4LTQ3MzE0MzJmLTVkOGItNGYyZS1iZTRkLTJkZjI0NTIwODFjNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNDA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDQwNVQyMzA3NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZGY0MDZiYWVkYzI5YjExODliOTBhMzRmYWQyY2EzNDJjZTJjMzVmMTA2YTJiMDg1ZjFhN2ExZDVjMzlkNWVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ogQrQDcfTwbBJk-_-QZBfEHr-AXnPx2rTN9CDSXPUAM"](https://private-user-images.githubusercontent.com/143021053/573699688-4731432f-5d8b-4f2e-be4d-2df2452081c5.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzU0MzA3NzcsIm5iZiI6MTc3NTQzMDQ3NywicGF0aCI6Ii8xNDMwMjEwNTMvNTczNjk5Njg4LTQ3MzE0MzJmLTVkOGItNGYyZS1iZTRkLTJkZjI0NTIwODFjNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNDA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDQwNVQyMzA3NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZGY0MDZiYWVkYzI5YjExODliOTBhMzRmYWQyY2EzNDJjZTJjMzVmMTA2YTJiMDg1ZjFhN2ExZDVjMzlkNWVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ogQrQDcfTwbBJk-_-QZBfEHr-AXnPx2rTN9CDSXPUAM"){kind=link}