Ma77Ball commented on PR #4292: URL: https://github.com/apache/texera/pull/4292#issuecomment-4058194568
@Yicong-Huang to address this comment (https://github.com/apache/texera/pull/4278#issuecomment-4058026542): The core issue is that the workflow currently has no pull_request trigger at all, which is why it doesn't run for anyone — committers or not. The fix simply adds the pull_request trigger with the standard event types (opened, synchronize, reopened), which is what makes GitHub automatically run the workflow for all PRs, including forks. The reason this works for fork contributors without explicit approval is that adding pull_request (not pull_request_target) to the trigger is GitHub's built-in mechanism for running CI on PRs. GitHub handles fork isolation automatically by running the workflow with read-only tokens and no access to secrets. No committer approval step is needed because GitHub's own sandboxing is what keeps fork PRs safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
