richardfogaca commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2897092187


##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -1693,6 +1713,57 @@ const FiltersConfigForm = (
                               )}
                             </CollapsibleControl>
                           </FormItem>
+                          {!isChartCustomization && (
+                            <StyledRowFormItem
+                              expanded={expanded}
+                              name={[
+                                'filters',
+                                filterId,
+                                'controlValues',
+                                'operatorType',
+                              ]}
+                              initialValue={currentOperatorType}
+                              label={
+                                <>
+                                  <StyledLabel>{t('Match type')}</StyledLabel>
+                                  &nbsp;
+                                  <InfoTooltip
+                                    placement="top"
+                                    tooltip={t(
+                                      'Warning: ILIKE queries may be slow on 
large datasets as they cannot use indexes effectively.',
+                                    )}
+                                  />
+                                </>
+                              }
+                            >
+                              <Select

Review Comment:
   The Match type options are duplicated here and in the Select filter control 
config. It would be better to share one source of truth to avoid drift



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to