bito-code-review[bot] commented on code in PR #38369:
URL: https://github.com/apache/superset/pull/38369#discussion_r2895520592
##########
superset-frontend/src/visualizations/presets/MainPreset.ts:
##########
@@ -101,7 +101,7 @@ export default class MainPreset extends Preset {
]
: [];
- const agGridTablePlugin = isFeatureEnabled(FeatureFlag.AgGridTableEnabled)
+ const agGridTablePlugin = true
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Feature flag bypassed</b></div>
<div id="fix">
Hardcoding the feature flag to `true` bypasses the feature flag system,
which is intended to control feature rollouts. This ensures the AgGridTable
plugin is always loaded, ignoring configuration settings. If enabling
unconditionally is the goal, simplify by removing the conditional entirely.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- const agGridTablePlugin =
isFeatureEnabled(FeatureFlag.AgGridTableEnabled)
- ? [new AgGridTableChartPlugin().configure({ key: VizType.TableAgGrid
})]
- : [];
+ const agGridTablePlugin = [new AgGridTableChartPlugin().configure({
key: VizType.TableAgGrid })];
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/0de5161/.cursor/rules/dev-standard.mdc#L81";>dev-standard.mdc:81</a>
</li>
</ul>
</details>
<small><i>Code Review Run #1681b0</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
