bito-code-review[bot] commented on code in PR #38414:
URL: https://github.com/apache/superset/pull/38414#discussion_r2892387327
##########
superset/mcp_service/sql_lab/schemas.py:
##########
@@ -115,6 +115,64 @@ class ExecuteSqlResponse(BaseModel):
)
+class SaveSqlQueryRequest(BaseModel):
+ """Request schema for saving a SQL query."""
+
+ database_id: int = Field(
+ ..., description="Database connection ID the query runs against"
+ )
+ label: str = Field(
+ ...,
+ description="Name for the saved query (shown in Saved Queries list)",
+ min_length=1,
+ max_length=256,
+ )
+ sql: str = Field(
+ ...,
+ description="SQL query text to save",
+ )
+ schema_name: str | None = Field(
+ None,
+ description="Schema the query targets",
+ alias="schema",
+ )
+ catalog: str | None = Field(None, description="Catalog name (if
applicable)")
+ description: str | None = Field(
+ None, description="Optional description of the query"
+ )
+
+ @field_validator("sql")
+ @classmethod
+ def sql_not_empty(cls, v: str) -> str:
+ if not v or not v.strip():
+ raise ValueError("SQL query cannot be empty")
+ return v.strip()
+
+ @field_validator("label")
+ @classmethod
+ def label_not_empty(cls, v: str) -> str:
+ if not v or not v.strip():
+ raise ValueError("Label cannot be empty")
+ return v.strip()
+
+
+class SaveSqlQueryResponse(BaseModel):
+ """Response schema for a saved SQL query."""
+
+ id: int = Field(..., description="Saved query ID")
+ label: str = Field(..., description="Query name")
+ sql: str = Field(..., description="SQL query text")
+ database_id: int = Field(..., description="Database ID")
+ schema_name: str | None = Field(None, description="Schema name",
alias="schema")
+ description: str | None = Field(None, description="Query description")
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing catalog field in response schema</b></div>
<div id="fix">
The SaveSqlQueryResponse schema omits the 'catalog' field, even though the
underlying SavedQuery model supports it and the request accepts it. This
creates incomplete API responses when catalog is provided. Include catalog in
the response for full property coverage.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
schema_name: str | None = Field(None, description="Schema name",
alias="schema")
catalog: str | None = Field(None, description="Catalog name (if
applicable)")
description: str | None = Field(None, description="Query description")
````
</div>
</details>
</div>
<small><i>Code Review Run #b1acaf</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
