aurokk opened a new pull request, #38454:
URL: https://github.com/apache/superset/pull/38454
Adds a mechanism to persist the upstream OAuth access token (from Superset
login) and reuse it for database connections, avoiding a second OAuth dance.
This is particularly useful for Trino deployments that share an identity
provider with Superset — and essential for MCP usage where no browser is
available to complete a database OAuth flow.
New config:
OAUTH_PROVIDERS[n].save_token = True # persist token at login time
DATABASE_OAUTH2_UPSTREAM_PROVIDERS = {"trino": "provider_name"} # use it
Changes:
- Add user_auth_tokens table (migration + UserAuthToken model)
- Override auth_user_oauth() in SupersetSecurityManager to save token
- Add save_user_provider_token / get_upstream_provider_token /
_refresh_upstream_provider_token to oauth2.py
- Inject upstream token in Database._get_sqla_engine() before falling back
to per-database OAuth2
- Add UserAuthTokenDAO
- Add unit tests for new oauth2 utilities
<!---
Please write the PR title following the conventions at
https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
