sha174n opened a new pull request, #38452: URL: https://github.com/apache/superset/pull/38452
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions -->The current has_subquery implementation relies on sqlglot's scope traversal, which is effective for standard SELECT statements but frequently returns an empty scope for raw SQL fragments, such as those used in Row-Level Security (RLS) filters. This results in subqueries going undetected even when the ALLOW_ADHOC_SUBQUERY feature flag is disabled. Key Changes - Refactored has_subquery in superset/sql/parse.py to use a recursive walker (.walk()) for comprehensive detection of Select, Union, and Subquery nodes within raw SQL expressions. - Enhanced extract_tables_from_statement to explicitly traverse subquery nodes when standard scope traversal yields no results, ensuring reliable table identification in nested expressions and CTEs. - Added regression tests in tests/unit_tests/sql/parse_tests.py covering various subquery types, set operations (UNION/EXCEPT/INTERSECT), and complex aliasing. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Ensure ALLOW_ADHOC_SUBQUERY is set to False. 2. Attempt to save an RLS filter containing a subquery (e.g., EXISTS (SELECT 1 FROM other_table)). The operation should be consistently blocked. 3. Execute unit tests: pytest tests/unit_tests/sql/parse_tests.py. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
