aminghadersohi commented on code in PR #36933: URL: https://github.com/apache/superset/pull/36933#discussion_r2891913407
########## tests/unit_tests/mcp_service/embedded_chart/tool/test_get_embeddable_chart.py: ########## @@ -0,0 +1,550 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Unit tests for MCP get_embeddable_chart tool +""" + +from datetime import datetime, timezone +from unittest.mock import MagicMock, patch + +import pytest + +from superset.mcp_service.chart.schemas import ( + ColumnRef, + FilterConfig, + TableChartConfig, + XYChartConfig, +) +from superset.mcp_service.embedded_chart.schemas import ( + GetEmbeddableChartRequest, + GetEmbeddableChartResponse, +) +from superset.mcp_service.embedded_chart.tool.get_embeddable_chart import ( + _ensure_guest_role_permissions, +) + + +class TestGetEmbeddableChartSchemas: + """Tests for get_embeddable_chart schemas.""" + + def test_request_with_xy_config(self): + """Test request with XY chart config (same as generate_chart).""" + config = XYChartConfig( + chart_type="xy", + x=ColumnRef(name="genre"), + y=[ColumnRef(name="sales", aggregate="SUM")], + kind="bar", + ) + request = GetEmbeddableChartRequest( + datasource_id=22, + config=config, + ) + assert request.datasource_id == 22 + assert request.config.chart_type == "xy" + assert request.config.x.name == "genre" + assert request.config.y[0].aggregate == "SUM" + assert request.config.kind == "bar" + assert request.ttl_minutes == 60 # default + assert request.height == 400 # default + + def test_request_with_table_config(self): + """Test request with table chart config.""" + config = TableChartConfig( + chart_type="table", + columns=[ + ColumnRef(name="genre"), + ColumnRef(name="sales", aggregate="SUM", label="Total Sales"), + ], + ) + request = GetEmbeddableChartRequest( + datasource_id="dataset-uuid-here", + config=config, + ttl_minutes=120, + height=600, + ) + assert request.datasource_id == "dataset-uuid-here" + assert request.config.chart_type == "table" + assert len(request.config.columns) == 2 + assert request.ttl_minutes == 120 + assert request.height == 600 + + def test_request_with_rls_rules(self): + """Test request with row-level security rules.""" + config = XYChartConfig( + chart_type="xy", + x=ColumnRef(name="date"), + y=[ColumnRef(name="count", aggregate="COUNT")], + kind="line", + ) + request = GetEmbeddableChartRequest( + datasource_id=123, + config=config, + rls_rules=[ + {"dataset": 123, "clause": "tenant_id = 42"}, + {"dataset": 123, "clause": "region = 'US'"}, + ], + ) + assert len(request.rls_rules) == 2 + assert request.rls_rules[0]["clause"] == "tenant_id = 42" + + def test_request_with_allowed_domains(self): + """Test request with allowed_domains for iframe security.""" + config = TableChartConfig( + chart_type="table", + columns=[ColumnRef(name="col1")], + ) + request = GetEmbeddableChartRequest( + datasource_id=1, + config=config, + allowed_domains=["https://example.com";, "https://app.example.com";], + ) + assert request.allowed_domains == [ + "https://example.com";, + "https://app.example.com";, + ] + + def test_request_ttl_validation(self): + """Test TTL minutes validation bounds.""" + config = TableChartConfig( + chart_type="table", + columns=[ColumnRef(name="col1")], + ) + # Valid min TTL + request = GetEmbeddableChartRequest( + datasource_id=1, + config=config, + ttl_minutes=1, + ) + assert request.ttl_minutes == 1 + + # Valid max TTL (1 week) + request = GetEmbeddableChartRequest( + datasource_id=1, + config=config, + ttl_minutes=10080, + ) + assert request.ttl_minutes == 10080 + + # Invalid TTL should raise + with pytest.raises(ValueError, match="greater than or equal to 1"): + GetEmbeddableChartRequest( + datasource_id=1, + config=config, + ttl_minutes=0, # below min + ) + + with pytest.raises(ValueError, match="less than or equal to 10080"): + GetEmbeddableChartRequest( + datasource_id=1, + config=config, + ttl_minutes=10081, # above max + ) + + def test_request_height_validation(self): + """Test height validation bounds.""" + config = TableChartConfig( + chart_type="table", + columns=[ColumnRef(name="col1")], + ) + # Valid min height + request = GetEmbeddableChartRequest( + datasource_id=1, + config=config, + height=100, + ) + assert request.height == 100 + + # Valid max height + request = GetEmbeddableChartRequest( + datasource_id=1, + config=config, + height=2000, + ) + assert request.height == 2000 + + # Invalid heights should raise + with pytest.raises(ValueError, match="greater than or equal to 100"): + GetEmbeddableChartRequest( + datasource_id=1, + config=config, + height=99, # below min + ) + + with pytest.raises(ValueError, match="less than or equal to 2000"): + GetEmbeddableChartRequest( + datasource_id=1, + config=config, + height=2001, # above max Review Comment: No change needed. Same as above — Pydantic v2's `ValidationError` inherits from `ValueError`, so `pytest.raises(ValueError)` works correctly for both TTL and height validation tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
