aminghadersohi commented on code in PR #36933: URL: https://github.com/apache/superset/pull/36933#discussion_r2891589207
########## superset/embedded_chart/view.py: ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from typing import Callable + +from flask import abort, current_app +from flask_appbuilder import expose +from flask_login import AnonymousUserMixin, login_user + +from superset import event_logger, is_feature_enabled +from superset.superset_typing import FlaskResponse +from superset.utils import json +from superset.views.base import BaseSupersetView, common_bootstrap_payload + + +class EmbeddedChartView(BaseSupersetView): + """Server-side rendering for embedded chart pages.""" + + route_base = "/embedded/chart" + + @expose("/") + @event_logger.log_this_with_extra_payload + def embedded_chart( + self, + add_extra_log_payload: Callable[..., None] = lambda **kwargs: None, + ) -> FlaskResponse: + """ + Server side rendering for the embedded chart page. + Expects ?permalink_key=xxx query parameter. + """ + if not is_feature_enabled("EMBEDDABLE_CHARTS_MCP"): + abort(404) + + # Log in as anonymous user for page rendering + # This view needs to be visible to all users, + # and building the page fails if g.user and/or ctx.user aren't present. + login_user(AnonymousUserMixin(), force=True) + + add_extra_log_payload( + embedded_type="chart", + ) + + bootstrap_data = { + "config": { + "GUEST_TOKEN_HEADER_NAME": current_app.config[ + "GUEST_TOKEN_HEADER_NAME" + ], Review Comment: Already addressed — line 122 uses `current_app.config.get('GUEST_TOKEN_HEADER_NAME', 'X-GuestToken')` with a sensible default. ########## superset/mcp_service/app.py: ########## @@ -324,6 +324,9 @@ def create_mcp_app( get_instance_info, health_check, ) +from superset.mcp_service.embedded_chart.tool import ( # noqa: F401, E402 + get_embeddable_chart, +) Review Comment: This follows the same pattern used by all other MCP tool imports in app.py (e.g. generate_chart, get_chart_data, etc.). The `# noqa: F401, E402` comments already signal these are side-effect imports. ########## superset-frontend/webpack.config.js: ########## @@ -300,6 +300,7 @@ const config = { menu: addPreamble('src/views/menu.tsx'), spa: addPreamble('/src/views/index.tsx'), embedded: addPreamble('/src/embedded/index.tsx'), + embeddedChart: addPreamble('/src/embeddedChart/index.tsx'), Review Comment: Already addressed — the entry uses `addPreamble('src/embeddedChart/index.tsx')` without a leading slash, matching the convention of all other entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
