jaymasiwal commented on PR #38162: URL: https://github.com/apache/superset/pull/38162#issuecomment-4006844909
I tested the PR using the preview environment. When filters fit in the bar (no overflow), the **“More filters (0)” button remains visible as expected**, which fixes the layout shift issue described in the PR. However, when clicking the button in this state, **nothing happens** because there is no overflow content to render. This seems to match the Copilot review note that `shouldShowButton` can be true while `popoverContent` is null. In this case the button is still rendered but the popover has no content. From a UX perspective it might be worth either: • disabling the button when `popoverContent` is null • or rendering the button without the popover wrapper when there is no content Just sharing the behavior observed during testing in the preview environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
