bito-code-review[bot] commented on code in PR #38407: URL: https://github.com/apache/superset/pull/38407#discussion_r2891499552
########## tests/unit_tests/mcp_service/test_auth_rbac.py: ########## @@ -0,0 +1,221 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Tests for MCP RBAC permission checking (auth.py).""" + +from unittest.mock import MagicMock, patch + +import pytest +from flask import g + +from superset.mcp_service.auth import ( + check_tool_permission, + CLASS_PERMISSION_ATTR, + MCPPermissionDeniedError, + METHOD_PERMISSION_ATTR, + PERMISSION_PREFIX, +) + + [email protected](autouse=True) +def enable_mcp_rbac(app): + """Re-enable RBAC for dedicated RBAC tests. + + The shared conftest disables RBAC for integration tests. This fixture + overrides that so we can test the actual permission checking logic. + """ + app.config["MCP_RBAC_ENABLED"] = True + yield + app.config.pop("MCP_RBAC_ENABLED", None) + + +class _ToolFunc: + """Minimal callable stand-in for a tool function in tests. + + Unlike MagicMock, this does NOT auto-create attributes on access, + so ``getattr(func, ATTR, None)`` properly returns None when the + attribute hasn't been set. + """ + + def __init__(self, name: str = "test_tool"): + self.__name__ = name + + def __call__(self, *args, **kwargs): + pass + + +def _make_tool_func( + class_perm: str | None = None, + method_perm: str | None = None, +) -> _ToolFunc: + """Create a tool function stub with optional permission attributes.""" + func = _ToolFunc() + if class_perm is not None: + setattr(func, CLASS_PERMISSION_ATTR, class_perm) + if method_perm is not None: + setattr(func, METHOD_PERMISSION_ATTR, method_perm) + return func + + +# -- MCPPermissionDeniedError -- + + +def test_permission_denied_error_message_basic(): + err = MCPPermissionDeniedError( + permission_name="can_read", + view_name="Chart", + ) + assert "can_read" in str(err) + assert "Chart" in str(err) + assert err.permission_name == "can_read" + assert err.view_name == "Chart" + + +def test_permission_denied_error_message_with_user_and_tool(): + err = MCPPermissionDeniedError( + permission_name="can_write", + view_name="Dashboard", + user="alice", + tool_name="generate_dashboard", + ) + assert "alice" in str(err) + assert "generate_dashboard" in str(err) + assert "Dashboard" in str(err) + + +# -- check_tool_permission -- + + +def test_check_tool_permission_no_class_permission_allows(app_context): + """Tools without class_permission_name should be allowed by default.""" + g.user = MagicMock(username="admin") + func = _make_tool_func() # no class_permission_name + assert check_tool_permission(func) is True + + +def test_check_tool_permission_no_user_denies(app_context): + """If no g.user, permission check should deny.""" + g.user = None + func = _make_tool_func(class_perm="Chart") + assert check_tool_permission(func) is False + + +def test_check_tool_permission_granted(app_context): + """When security_manager.can_access returns True, permission is granted.""" + g.user = MagicMock(username="admin") + func = _make_tool_func(class_perm="Chart", method_perm="read") + + with patch("superset.extensions.appbuilder") as mock_appbuilder: + mock_appbuilder.sm.can_access.return_value = True + result = check_tool_permission(func) + + assert result is True + mock_appbuilder.sm.can_access.assert_called_once_with("can_read", "Chart") + + +def test_check_tool_permission_denied(app_context): + """When security_manager.can_access returns False, permission is denied.""" + g.user = MagicMock(username="viewer") + func = _make_tool_func(class_perm="Dashboard", method_perm="write") + + with patch("superset.extensions.appbuilder") as mock_appbuilder: + mock_appbuilder.sm.can_access.return_value = False + result = check_tool_permission(func) + + assert result is False + mock_appbuilder.sm.can_access.assert_called_once_with("can_write", "Dashboard") + + +def test_check_tool_permission_default_method_is_read(app_context): + """When no method_permission_name is set, defaults to 'read'.""" + g.user = MagicMock(username="admin") + func = _make_tool_func(class_perm="Dataset") + # No method_perm set - should default to "read" + + with patch("superset.extensions.appbuilder") as mock_appbuilder: + mock_appbuilder.sm.can_access.return_value = True + check_tool_permission(func) Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Return Value Assertion</b></div> <div id="fix"> The test checks the permission call but omits asserting the return value. This could miss bugs in the function's logic. Add the assertion to ensure completeness. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion result = check_tool_permission(func) assert result is True ```` </div> </details> </div> <small><i>Code Review Run #d1be71</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/mcp_service/mcp_config.py: ########## @@ -45,6 +45,10 @@ # MCP Debug mode - shows suppressed initialization output in stdio mode MCP_DEBUG = False +# MCP RBAC - when True, tools with class_permission_name are checked +# against the FAB security_manager before execution. +MCP_RBAC_ENABLED = True Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Config not overrideable</b></div> <div id="fix"> The added MCP_RBAC_ENABLED config is not included in the get_mcp_config defaults, so users cannot override it in superset_config.py as the comment suggests. This prevents disabling RBAC when needed. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` - "MCP_DEBUG": MCP_DEBUG, - **MCP_SESSION_CONFIG, - **MCP_CSRF_CONFIG, + "MCP_DEBUG": MCP_DEBUG, + "MCP_RBAC_ENABLED": MCP_RBAC_ENABLED, + **MCP_SESSION_CONFIG, + **MCP_CSRF_CONFIG, ``` </div> </details> </div> <small><i>Code Review Run #d1be71</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
